PowerToys icon indicating copy to clipboard operation
PowerToys copied to clipboard

[Settings] Removed `muxc` prefix

Open Jay-o-Way opened this issue 3 years ago • 6 comments

Quick deletion. Quick run in VS gave no problems.

Summary of the Pull Request

@niels9001 said the muxc could be removed. (in https://github.com/microsoft/PowerToys/pull/19592#discussion_r950869100) Is there anything more that could be removed, related to the prefix? Like a Nuget or a dependency or whatever?

PR Checklist

  • [x] Closes: #20181
  • [x] Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
  • [ ] Tests: Added/updated and all pass
  • [x] Localization: All end user facing strings can be localized
  • [ ] Dev docs: Added/updated
  • [ ] New binaries: Added on the required places
  • [ ] Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

Gave it a quick run in Visual Studio and seems to work fine. (but let me know if it doesn't)

Jay-o-Way avatar Aug 30 '22 10:08 Jay-o-Way

This needs a tracking issue

crutkas avatar Aug 30 '22 15:08 crutkas

@Jay-o-Way Has this been tested? We need to have a prefix for the AnimatedIcon state stuff..

niels9001 avatar Aug 30 '22 15:08 niels9001

Has this been tested?

As mentiond above: quick Debug in Visual Studio didn't show problems.

AnimatedIcon

You mean the overwritten settings for the Chevron for the Expanders? Or something with SearchAnimatedIcon? I think we could do without that customization all together :)

Jay-o-Way avatar Aug 30 '22 16:08 Jay-o-Way

That issue is an epic and needs to be broken down into smaller bits that can be independently tracked like this. They can be referenced but that issue itself is just a bucket of random issues that deal with UI at quick glance. You cannot have detailed discussions if needed and conversations become muddled due to the sheer number of stuff there

crutkas avatar Aug 30 '22 16:08 crutkas

Too late for 62 as we plan to release tomorrow.

Also this has merge conflicts.

crutkas avatar Sep 05 '22 19:09 crutkas

Can I also remove the line xmlns:muxc="using:Microsoft.UI.Xaml.Controls" now?

Jay-o-Way avatar Sep 17 '22 14:09 Jay-o-Way

Can I also remove the line xmlns:muxc="using:Microsoft.UI.Xaml.Controls" now?

Just added a commit for that :)

jaimecbernardo avatar Sep 20 '22 16:09 jaimecbernardo