PowerToys icon indicating copy to clipboard operation
PowerToys copied to clipboard

[Keyboard Manager]: After deleting any row keyboard focus shift to 'Ok' button.

Open DhananjaySaini007 opened this issue 3 years ago • 11 comments

Microsoft PowerToys version

0.45.0

Running as admin

  • [ ] Yes

Area(s) with issue?

Keyboard Manager

Steps to reproduce

Steps to reproduce Test Environment: OS: Windows 11 Version Dev App version: 0.45.0 App name: PowerToys Screen Reader: Narrator Tool: Accessibility Insight for Windows

Repro Steps:

1 Launch 'PowerToys' application.

  1. In General tab, navigate to 'Keyboard manager’ button and activate.
  2. Navigate to ‘Remap a key’ and activate it using enter/Space key.
  3. Now, Remap a key dialog box will appear.
  4. Navigate to 'Delete Remapping' button and Activate it
  5. Observe the issue

User Impact: -> Keyboard and Screen Reader user are impacted here as purpose is conveyed by its Keyboard.

Guidelines Reference:- https://www.w3.org/TR/WCAG21/#focus-order

Attachments:

https://user-images.githubusercontent.com/91203131/134497255-b1944432-6261-4afd-b445-61dc4b5681fd.mp4

Powertoys - After deleting any row keyboard focus shift to 'Ok' button

✔️ Expected Behavior

After deleting a row the focus should move to the very next element.

❌ Actual Behavior

After deleting any row keyboard focus shift to 'Ok' button.

Other Software

No response

DhananjaySaini007 avatar Sep 23 '21 11:09 DhananjaySaini007

what should the expected behavior here be then when all are deleted? What should have focus

crutkas avatar Dec 08 '21 01:12 crutkas

Hi @crutkas
After Deleting all the Rows, the expected element to have focus is "Add a Remap" button.

DhananjaySaini007 avatar Dec 08 '21 12:12 DhananjaySaini007

Where in documentation is this guidance? I’m trying to be formulaic here versus guessing.

This is a well established pattern for what this app does so we should be able to point at a doc

crutkas avatar Dec 10 '21 03:12 crutkas

This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 5 days. It will be closed if no further activity occurs within 5 days of this comment.

ghost avatar Dec 15 '21 08:12 ghost

Keyboard focus should move to 'add a remap' button to avoid extra navigation after deleting a row,

DhananjaySaini007 avatar Dec 20 '21 12:12 DhananjaySaini007

@DhananjaySaini007 my question is where the documented behavior this should take when this scenario takes place. This is a common pattern. 2.4.3 can be taken arbitrarily. Your take and my take on that definition could differ and this is an opinion based due to the subjective nature.

crutkas avatar Dec 20 '21 17:12 crutkas

This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 5 days. It will be closed if no further activity occurs within 5 days of this comment.

ghost avatar Dec 25 '21 20:12 ghost

Please find the documented behavior from the below link in WCAG's 2.4.3, https://www.w3.org/TR/UNDERSTANDING-WCAG20/navigation-mechanisms-focus-order.html.

DhananjaySaini007 avatar Jan 17 '22 13:01 DhananjaySaini007

This issue is still repro on version 0.76.2 hence reactivating it.

Priyanshu073 avatar Jan 05 '24 05:01 Priyanshu073

https://github.com/microsoft/PowerToys/assets/87321414/d8f3ef7e-02e8-4890-abbe-a6269d63a920

Priyanshu073 avatar Jan 05 '24 05:01 Priyanshu073

This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 5 days. It will be closed if no further activity occurs within 5 days of this comment.