PowerShellForGitHub icon indicating copy to clipboard operation
PowerShellForGitHub copied to clipboard

Only the TLS 1.2 protocol is supported

Open variableresistor opened this issue 11 months ago • 0 comments

Feature Idea Summary

PowerShell Core supports the faster TLS 1.3 protocol, but the module forces it to use 1.2.

Feature Idea Additional Details

In the GitHubCore.ps1 file:

[Net.ServicePointManager]::SecurityProtocol=[Net.SecurityProtocolType]::Tls12

Requested Assignment

Don't care. I can do it if the PR doesn't take too long. Just change the above code to:

if ($PSVersionTable.PSVersion -lt 7.0.0)
{
    [Net.ServicePointManager]::SecurityProtocol=[Net.SecurityProtocolType]::Tls12
}

and in the finally block:

if ($PSVersionTable.PSVersion -lt 7.0.0)
{
    [Net.ServicePointManager]::SecurityProtocol = $originalSecurityProtocol
}

PowerShell 6 isn't supported anymore, so anything less than 7 should use TLS 1.2.

Operating System

All

PowerShell Version

Name                           Value
----                           -----
PSVersion                      7.4.6
PSEdition                      Core
GitCommitId                    7.4.6
OS                             Microsoft Windows 10.0.19045
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           1.1.0.1
WSManStackVersion              3.0

Module Version

Running: 0.17.0 Installed: 0.17.0

variableresistor avatar Jan 08 '25 00:01 variableresistor