PowerPlatformConnectors icon indicating copy to clipboard operation
PowerPlatformConnectors copied to clipboard

[paconn] Send success messages to stdout not stderr

Open remyblok opened this issue 10 months ago • 3 comments

paconn sends success messages like Login successful. to the stderr. When integrating paconn into other tools/pipelines this causes strange behaviour.

This PR changes:

  • All messages are routed through the util helpers, either DisplayMessage or DisplayError
  • Nowhere Print() is used directly
  • Ability to force flush of a message, usefull when login displays the device code

remyblok avatar Apr 25 '24 11:04 remyblok

Hello @remyblok,

May I know the reason to modify paconn cli tool? Are you from Microsoft?

vmanoharas avatar Apr 25 '24 17:04 vmanoharas

Hello @remyblok,

Kindly let's know why did you modify the paconn tool, as this is Microsoft's tool and our team is responsible to modify this.

vmanoharas avatar Apr 29 '24 16:04 vmanoharas

Hi @vmanoharas,

Sorry for the delayed response.

I'm not from Microsoft. I'm just giving the paconn tool some love. The README states the project is open to contribution. I'm using the paconn tooling and have some issues with it. So, I can modify it for myself, but I'd like to share back the modifications to the community. I know the PAC CLI also has similar functions, but that tool is not compatible with paconn and is closed-source.

remyblok avatar Apr 30 '24 13:04 remyblok

Hello @remyblok,

Thank you very much for your contribution, Microsoft team will take care of updating with necessary changes. Apologies for saying this. Kindly close this PR.

vmanoharas avatar May 06 '24 12:05 vmanoharas

That's unfortunate. I had more changes in the works. Like switching from ADAL to MSAL and support for multiple logged in accounts due to that switch. Guess what will be used just by me.... Please contact me if we can arrange something else.

I'll close this request now.

remyblok avatar May 10 '24 14:05 remyblok