PTVS icon indicating copy to clipboard operation
PTVS copied to clipboard

Django completions in html file does not work.

Open linette-zyy opened this issue 3 years ago • 6 comments

Environment image

Actual result html

Expected result

  1. Open the app/about.html in Django Web Project
  2. Typing a vertical bar '|' character after a variable brings up completions for filters including 'upper', and each one has a tooltip image
  3. Typing opening brace and percent '{%' brings up completions for tags including 'if' and 'extends', they currently don't have tooltips image
  4. Typing double opening brace '{{' brings up completions for variables passed in to the template (see views.py). image

linette-zyy avatar Aug 02 '21 06:08 linette-zyy

Django (html) completions is owned by another team. This should be transferred to that team (internal DevDiv bug)

rchiodo avatar Aug 02 '21 15:08 rchiodo

It's possible that we accidentally removed this support after hugues left. So if there are complaints we can try bringing it back. See https://github.com/microsoft/PTVS/commits/main/Python/Product/Django.

greazer avatar Aug 04 '21 23:08 greazer

Probably easy to add stuff back. Should do this sooner rather than later so we can see if there's more work to account for changes from the HTML LS.

rchiodo avatar Aug 04 '21 23:08 rchiodo

This might not work. Django intellisense is hooking into the old engine. There's no good way to hook into pylance for the same thing

rchiodo avatar Aug 11 '21 21:08 rchiodo

Readding this isn't going to be trivial.

rchiodo avatar Aug 11 '21 21:08 rchiodo

Here's a branch indicating all the stuff that won't work: https://github.com/rchiodo/PTVS/tree/rchiodo/django_intellisense_readd

rchiodo avatar Aug 11 '21 21:08 rchiodo

Closing as a dupe of https://github.com/microsoft/pylance-release/issues/3701

judej avatar Jan 17 '23 23:01 judej