Oryx
Oryx copied to clipboard
Appending node modules bin to suffix instead of prefix in PATH
Context
For non node modules extraction based deployment, there was no updating of PATH env variable. Cx who had yarn run start command (taking example), their app will start since yarn used was that of which came with blessed image (even though the one in .bin was broken due to no preservation of symlink).
Going ahead with node modules extraction based deployment involving customer building code locally, the PATH variable updated in this workflow will set preference to startup command script located at .bin, which is causing site failures (for customers who are not preserving symlinks in .bin), especially for those having yarn as startup.
Screenshot to help understand better:
Validation:
Start:
- [ ] The purpose of this PR is explained in this message or in an issue. If an issue please include a reference as #<issue_number>.
- [ ] Tests are included and/or updated for code changes.
- [ ] Proper license headers are included in each file.