Oryx icon indicating copy to clipboard operation
Oryx copied to clipboard
verified publisher icon microsoft

Correct spelling mistake in filename supportedPlatformVerions.md -> supportedPlatformVersions.md

Open Turbo549 opened this issue 3 years ago • 3 comments

  • [x] The purpose of this PR is explained in this message or in an issue. If an issue please include a reference as #<issue_number>.
  • [x] Tests are included and/or updated for code changes.
  • [x] Proper license headers are included in each file.

Turbo549 avatar Jul 29 '22 16:07 Turbo549

Thank you @Turbo549 for opening this PR and fixing this typo! Would it be possible for you to also update the two places where we reference this file (with the typo in the name): https://github.com/microsoft/Oryx/blob/main/build/tools/SharedCodeGenerator/Program.cs - Line 100 https://github.com/microsoft/Oryx/blob/main/README.md?plain=1 - Line 31

daniv-msft avatar Jul 29 '22 17:07 daniv-msft

Thank you @Turbo549 for opening this PR and fixing this typo! Would it be possible for you to also update the two places where we reference this file (with the typo in the name): https://github.com/microsoft/Oryx/blob/main/build/tools/SharedCodeGenerator/Program.cs - Line 100 https://github.com/microsoft/Oryx/blob/main/README.md?plain=1 - Line 31

Terribly sorry I missed those refs... I had searched, but that doesn't work in the forked repo.

Turbo549 avatar Jul 29 '22 20:07 Turbo549

Thank you @Turbo549 for opening this PR and fixing this typo! Would it be possible for you to also update the two places where we reference this file (with the typo in the name): https://github.com/microsoft/Oryx/blob/main/build/tools/SharedCodeGenerator/Program.cs - Line 100 https://github.com/microsoft/Oryx/blob/main/README.md?plain=1 - Line 31

Terribly sorry I missed those refs... I had searched, but that doesn't work in the forked repo.

No worries at all! Thanks again for sending a PR for this. I'll start the "Oryx-Validation" pipeline for this PR, and once it completes we'll be able to merge it. :)

daniv-msft avatar Jul 29 '22 20:07 daniv-msft

@Turbo549 FYI, I went on vacation soon after approving this PR and I didn't have a chance to merge it before leaving. Now that I'm back, I can see that multiple merge conflicts happen now due to other changes being checked in in the last couple of weeks by other team members. Rather than asking you to spend time to resolve them, I reopened a separate PR based on the latest main version: https://github.com/microsoft/Oryx/pull/1527

Thanks again for making this change! I'm going to close this one.

daniv-msft avatar Aug 19 '22 18:08 daniv-msft