add liblzma-dev to python build

[joshspicer]

Relevant issue: https://github.com/microsoft/vscode-dev-containers/issues/1477

The build of oryx that is consumed by Codespaces has a version of python where the lzma library was seemingly not present at compile-time, causing issues seen above.

I believe this is the right place to put a build-time dependency for the build we get in the vso image. Please correct me if i'm wrong @william-msft !

[william-msft]

Relevant issue: microsoft/vscode-dev-containers#1477

The build of oryx that is consumed by Codespaces has a version of python where the lzma library was seemingly not present at compile-time, causing issues seen above.

I believe this is the right place to put a build-time dependency for the build we get in the vso image. Please correct me if i'm wrong @william-msft !

Hi @joshspicer ! Would this be for dynamic installation or having this pre-cached in Codespaces vso image? If the latter, then we'd have to update in the VSO image: https://github.com/microsoft/Oryx/blob/main/images/build/Dockerfiles/vso.focal.Dockerfile

This can also be dynamically installed by running:

• ./build/buildBuildImages.sh -t vso-focal
• docker run -it -v C:\Repos\Oryx\tests\SampleApps\:/tmp/SampleApps oryx/build:vso-focal /bin/bash

[joshspicer]

Hey @william-msft! I think both would probably want to be patched at the same time? But yes, my specific goal was to fix it in the vso image

[william-msft]

Hey @william-msft! I think both would probably want to be patched at the same time? But yes, my specific goal was to fix it in the vso image

This looks good to me. I would be great if you could double check the library with using the steps displayed above. Would you mind pushing a new commit. The ADO pipeline seems to be stuck since your last commit:

[joshspicer]

hmm, following the testing steps above, this didn't seem to help :/

[ericLemanissier]

I think this can be closed, now that https://github.com/microsoft/vscode-dev-containers/issues/1477 is fixed