OpenAPI.NET icon indicating copy to clipboard operation
OpenAPI.NET copied to clipboard

Initial changes for serializing JSON Schema

Open darrelmiller opened this issue 1 year ago • 5 comments

darrelmiller avatar Apr 22 '24 04:04 darrelmiller

@MaggieKimani1 I merged the release/2.0.0 branch into here and there are now more failing tests. I have been looking at the extensionskeyword. I am starting to think that we won't be able to use an extension keyword. I suspect we will need to use a UnrecognizedKeyword class for 'x-' properties because the ExtensionKeyword does not serialize. I'm not sure why though.

darrelmiller avatar May 09 '24 04:05 darrelmiller

I'm still on the fence as to whether it is easier to fix the tests in this PR or to re-apply the changes in this PR to the main feature branch. Whatever is easier.

darrelmiller avatar May 09 '24 04:05 darrelmiller

I'm still on the fence as to whether it is easier to fix the tests in this PR or to re-apply the changes in this PR to the main feature branch. Whatever is easier.

I can try cherry-pick the changes and apply them to the v2 branch just to see if there'll be much of a difference and if the tests will still fail.

MaggieKimani1 avatar May 09 '24 09:05 MaggieKimani1

I'm still on the fence as to whether it is easier to fix the tests in this PR or to re-apply the changes in this PR to the main feature branch. Whatever is easier.

I can try cherry-pick the changes and apply them to the v2 branch just to see if there'll be much of a difference and if the tests will still fail.

Update: Most of these changes are crucial especially the serialization ones so I've ended up lifting almost all of them. Now we have 99 tests failing on the V2 branch vs around 40 on this branch 😢 Maybe we can work on cleaning up this branch instead?

MaggieKimani1 avatar May 09 '24 12:05 MaggieKimani1

Quality Gate Failed Quality Gate failed

Failed conditions
28.9% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

sonarqubecloud[bot] avatar Jun 18 '24 12:06 sonarqubecloud[bot]