OCR-Form-Tools icon indicating copy to clipboard operation
OCR-Form-Tools copied to clipboard

Published 20 hours ago • verified publisher icon microsoft

Version update notification

Open yongbing-chen opened this issue 4 years ago • 3 comments

new feature: Version update notification

add a file "/src/react/components/common/version-info.json" like this: { "tag":"ga", "versions": { "ga": { "version": "2.0.0", "date":"2020-06-11", "commit": "b148092" }, "preview": { "version": "2.1", "date":"2020-09-15", "commit": "b92b73b" } } } Compare local version info with server side, if the server side version is higher, notify user new version avaliable.

yongbing-chen avatar Sep 18 '20 06:09 yongbing-chen

Thanks Yongbing for the PR! As we discussed, can we have design spec first, so everyone can know the key design decisions? Which can also help the code review.

kunzms avatar Sep 18 '20 18:09 kunzms

I'm was not able to see any notifications.

alex-krasn avatar Sep 21 '20 20:09 alex-krasn

I'm was not able to see any notifications, axios request returning 404.

That's because the file "version-info.json" hasn't been committed to master yet. It'll be committed with this commit.

To test, change "versionInfoUrl" in "src/common/constants.ts" to "https://raw.githubusercontent.com/microsoft/OCR-Form-Tools/yongbing-chen/version-check/src/react/components/common/version-info.json".

Next time, please note how to test when creating PR

stew-ro avatar Sep 21 '20 20:09 stew-ro