NubesGen icon indicating copy to clipboard operation
NubesGen copied to clipboard

Add support for Azure Container Apps

Open cmaneu opened this issue 2 years ago • 5 comments

Waiting for Terraform support of ACA

cmaneu avatar Jun 07 '22 09:06 cmaneu

https://learn.microsoft.com/en-us/samples/azure-samples/container-apps-azapi-terraform/container-apps-azapi-terraform/

SandraAhlgrimm avatar Nov 15 '22 08:11 SandraAhlgrimm

Hey @SandraAhlgrimm, Great catch! Would you like to work on this task? If so, this is were I would start:

  • [ ] Test the mentioned sample
  • [ ] Review the existing TF modules (I don't remember your level of fluency about Terraform)
    • Having the proper
  • [ ] Remove Dapr-specific things. Dapr support is interesting, but not all ACA users are DAPR users. Let's ship a simple version first
  • [ ] Look at our existing Application Insights template. I think these ones are outdated. It would make sense to create a new Azure Monitor / AI TF module, and leverage it in this ACA module.

What do you think?

cmaneu avatar Nov 16 '22 16:11 cmaneu

Yes, please assign it to me. I’d love to get through the „nubesgen add a new feature“ process first before thinking about the refactoring you suggested.

Christopher MANEU @.***> schrieb am Mi. 16. Nov. 2022 um 17:09:

Hey @SandraAhlgrimm https://github.com/SandraAhlgrimm, Great catch! Would you like to work on this task? If so, this is were I would start:

  • Test the mentioned sample
  • Review the existing TF modules (I don't remember your level of fluency about Terraform)
    • Having the proper
  • Remove Dapr-specific things. Dapr support is interesting, but not all ACA users are DAPR users. Let's ship a simple version first
  • Look at our existing Application Insights template. I think these ones are outdated. It would make sense to create a new Azure Monitor / AI TF module, and leverage it in this ACA module.

What do you think?

— Reply to this email directly, view it on GitHub https://github.com/microsoft/NubesGen/issues/322#issuecomment-1317266540, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABHZDW5OZDGQCSN627SYI23WIUBMFANCNFSM5YCFKPRQ . You are receiving this because you were mentioned.Message ID: @.***>

SandraAhlgrimm avatar Nov 16 '22 19:11 SandraAhlgrimm

Yes @SandraAhlgrimm this is clearly the best approach! And ACA support would help a ton of people.

jdubois avatar Nov 17 '22 08:11 jdubois

HI @cmaneu, let's wait until ACA is in the official azurerm terraform project https://github.com/hashicorp/terraform-provider-azurerm/pull/18008

It should be there soon, and it will ease adding this feature. Otherwise, we'll have to update it anyhow as soon as it gets released.

SandraAhlgrimm avatar Nov 21 '22 14:11 SandraAhlgrimm