NimbusML icon indicating copy to clipboard operation
NimbusML copied to clipboard

Published 20 hours ago • verified publisher icon microsoft

Use environment markers instead of modifying _install_requires

Open ianlini opened this issue 5 years ago • 5 comments

Fixes #237.

Please see #237 for more information.

ianlini avatar Aug 20 '19 07:08 ianlini

The Windows Py35 pipeline failed when installing enum. I have tried to install my version of nimbusml using Python 3.5.7 with pyenv and ubuntu 18.04. The result is correct and the dependencies shouldn't include enum. I have no idea why the pipeline try to install enum.

ianlini avatar Aug 20 '19 08:08 ianlini

CLA assistant check
All CLA requirements met.

msftclas avatar Jan 10 '20 10:01 msftclas

After a few hours of investigation, I found that the environment marker syntax I used may be wrong in the Py35 environment. Luckily, after upgrading setuptools, the problem is resolved. It's actually quite usual to upgrade pip, setuptools and wheel before doing anything.

ianlini avatar Jan 10 '20 11:01 ianlini

@ganik Could you take a look at this old PR?

ianlini avatar Jan 10 '20 11:01 ianlini

@pieths Could you take a look at this old PR? Thanks.

ianlini avatar Feb 13 '20 09:02 ianlini