MixedRealityToolkit-Unity icon indicating copy to clipboard operation
MixedRealityToolkit-Unity copied to clipboard

Published 20 hours ago • verified publisher icon microsoft

[MRTK3] Input Simulator controls are broken

Open Zee2 opened this issue 2 years ago • 1 comments

Describe the bug

You can't hold down spacebar + control to move the hand, select, and rotate anymore. You used to be able to. (Previously in MRTK3)

In addition, if you try and use control only, the simulator gets into a state where the left mouse button doesn't even initiate a grab anymore. This makes it basically impossible to do any kind of rotations with the input sim. The only way to do it is to use the T/Y toggle system, but even then it's impossible to do a grab in-place. It requires you to move the hand during your rotation, which is extremely kludgy.

@keveleigh, I wouldn't be terribly surprised if that has something to do with the input system changes we did a while ago?

To reproduce

Use input sim, try and rotate an object.

Expected behavior

You should be able to hold down spacebar to make the right hand appear, and then also hold control to enable/disable rotation, all the while the LMB should still function.

Your setup (please complete the following information)

  • MRTK3 mrtk3 branch

Zee2 avatar Jul 26 '22 19:07 Zee2

We may be replacing our current input simulator with XRI's new one in 2.3. See #11282.

Zee2 avatar Dec 15 '22 04:12 Zee2

@srinjoym can you verify in editor? @shaynie can you investigate pulling in the new simulator from 2.3

AMollis avatar Mar 03 '23 23:03 AMollis

I tried the new XRI toolkit 2.3 simulator, and I don't recommend switching to it for GA. Pulling in XRI 2.3 did not seem to break any input in editor on Hololens, so we should still consider it for GA.

shaynie avatar Mar 30 '23 16:03 shaynie

Tried out the simulator and compared to the MRTK 2 rotation controls. Here are the differences I found:

  1. User needs to hold "alt" to rotate with left hand (as opposed to holding "ctrl" for both left and right as in MRTK 2). This is already documented.
  2. I was able to use spacebar + ctrl to rotate and select objects, so it seems like the issue Finn ran into above has been fixed.
  3. The MRTK 2 simulator would lock the object's translation when trying to rotate. MRTK 3 does not do this, the object moves around while rotating. This makes it much harder to rotate an object in place.

Overall, I would say the simulator is functioning as expected other than the translation locking bug. I will make a PR to fix that and then close this issue

srinjoym avatar Apr 10 '23 16:04 srinjoym