Bugfix - Fix catalog displayname being passed as argument instead of catalog id

[n9294651]

Pull Request (PR) description

This PR reverts #6013 and provides the correct fix.

Previously $Results.CatalogId was updated from being assigned $Catalog.Id to $Catalog.DisplayName. This caused flow-on issues where Get-MgBetaEntitlementManagementAccessPackageCatalogAccessPackageResource calls were failing due to being given the Catalog DisplayName as a parameter instead of the Catalog Id. This was catered for already when the catalog guid was assigned to a new variable but that variable wasn't used.

https://github.com/microsoft/Microsoft365DSC/commit/41649b15fcb75485896dd00ffbb003458c0b133a#diff-89344a5e420fd38276b064d760ff189ed4a83fa6c6c07db49b65cdb4fa123fdcR170

This Pull Request (PR) fixes the following issues

- Fixes #4032 (previously closed)

https://github.com/microsoft/Microsoft365DSC/issues/4032

Task list

• [X ] Added an entry to the change log under the Unreleased section of the file CHANGELOG.md. Entry should say what was changed and how that affects users (if applicable), and reference the issue being resolved (if applicable).
• [ ] Resource parameter descriptions added/updated in the schema.mof.
• [ ] Resource documentation added/updated in README.md.
• [ ] Resource settings.json file contains all required permissions.
• [ ] Examples appropriately added/updated.
• [ ] Unit tests added/updated.
• [ X] New/changed code adheres to DSC Community Style Guidelines.

[NikCharlebois]

Please update the changelog and we will merge

[FabienTschanz]

@n9294651 Please update the PR, thank you.

[n9294651]

@FabienTschanz good to go?

[FabienTschanz]

From my side it looks good, but I can‘t approve or merge. We‘ll have to wait for one of the maintainers.