Microsoft365DSC icon indicating copy to clipboard operation
Microsoft365DSC copied to clipboard

Existing integration tests do not apply to pull requests, only push

Open Borgquite opened this issue 1 year ago • 2 comments

Sorry, I think this got missed out of the discussion on #4481.

The existing code coverage and integration tests do not currently apply on pull requests - they appear to be configured on 'push' only.

https://github.com/microsoft/Microsoft365DSC/blob/Dev/.github/workflows/Global%20-%20Integration%20-%20AAD.yml

The exception is the Unit Tests, which apply on push and pull requests

https://github.com/microsoft/Microsoft365DSC/blob/Dev/.github/workflows/Unit%20Tests.yml

In other DSC projects I've seen integration tests applied to pull requests - then bugs get picked up more quickly by the person submitting the change?

Looks like a fairly simple change, if it's agreed to I think I can do it!

Borgquite avatar Mar 25 '24 12:03 Borgquite

I think the team wants to keep some control over the integration tenant and only run integration tests on PRs that have been approved. Otherwise, anyone can submit a bogus Pull Request that would modify the tenant's configuration without any approvals.

NikCharlebois avatar Mar 27 '24 20:03 NikCharlebois

@NikCharlebois Ah yes, I understand that. It's a shame - I'd love to try to work on the integration tests, but it's very hard to do without feedback as to whether it's working or not.

I guess the ideal solution would be for Microsoft to allow trial tenants or developer tenants to be created programmatically - even if just for this project :)

Borgquite avatar Mar 28 '24 12:03 Borgquite