Microsoft365DSC icon indicating copy to clipboard operation
Microsoft365DSC copied to clipboard

PR: Add group display name to Intune Assignment (Batch 1)

Open William-Francillette opened this issue 1 year ago • 4 comments

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

  • IntuneAccountProtectionLocalAdministratorPasswordSolutionPolicy
    • Added support for assignment GroupDisplayName
  • IntuneAccountProtectionLocalUserGroupMembershipPolicy
    • Added support for assignment GroupDisplayName
  • IntuneAccountProtectionPolicy
    • Added support for assignment GroupDisplayName
  • IntuneAntivirusPolicyWindows10SettingCatalog
    • Added support for assignment GroupDisplayName
  • IntuneAppConfigurationPolicy
    • Added support for assignment GroupDisplayName
  • IntuneApplicationControlPolicyWindows10
    • Added support for assignment GroupDisplayName
  • IntuneASRRulesPolicyWindows10
    • Added support for assignment GroupDisplayName
  • IntuneDeviceCompliancePolicyAndroid
    • Added support for assignment GroupDisplayName
  • IntuneDeviceCompliancePolicyAndroidDeviceOwner
    • Added support for assignment GroupDisplayName
  • IntuneDeviceCompliancePolicyAndroidWorkProfile
    • Added support for assignment GroupDisplayName
  • IntuneDeviceCompliancePolicyiOs
    • Added support for assignment GroupDisplayName
  • IntuneDeviceCompliancePolicyMacOS
    • Added support for assignment GroupDisplayName
  • IntuneDeviceCompliancePolicyWindows10
    • Added support for assignment GroupDisplayName

William-Francillette avatar Feb 14 '24 18:02 William-Francillette

@NikCharlebois @ykuijs - not sure why but the test fails due to function not found but added to M365DSCUtil module so until it gets merged it will fail

William-Francillette avatar Feb 20 '24 20:02 William-Francillette

Now understand what you mean with the comment about the alternative solution being implemented in the issue. Didn't find it right away in this PR, but overlooked the comment that you only implemented it on one resource 😉

Will add a comment to the issue.

ykuijs avatar Feb 26 '24 10:02 ykuijs

Quick comment: Please also correct the changelog. Currently there are two Unreleased sections.

ykuijs avatar Feb 26 '24 19:02 ykuijs

  • Added support for groupDisplayName for an additional 7 resources

    • IntuneDeviceConfigurationAdministrativeTemplatePolicyWindows10
    • IntuneDeviceConfigurationCustomPolicyWindows10
    • IntuneDeviceConfigurationDefenderForEndpointOnboardingPolicyWindows10
    • IntuneDeviceConfigurationDeliveryOptimizationPolicyWindows10
    • IntuneDeviceConfigurationDomainJoinPolicyWindows10
    • IntuneDeviceConfigurationEmailProfilePolicyWindows10
    • IntuneDeviceConfigurationEndpointProtectionPolicyWindows10
  • Also added groupDisplayName for the All Users and All Devices assignments (M365DSCDRGUtil: ConvertFrom-IntunePolicyAssignment) image

William-Francillette avatar Feb 27 '24 20:02 William-Francillette