Microsoft365DSC icon indicating copy to clipboard operation
Microsoft365DSC copied to clipboard

Issue 2158

Open andikrueger opened this issue 2 years ago • 1 comments

Pull Request (PR) description

Refactoring of the reporting functions

Fixes #2158

andikrueger avatar Jul 29 '22 18:07 andikrueger

Those functions are internal and should not be called directly IMHO. All three functions are called by ‘ New-M365DSCReportFromConfiguration’. This function handles the changes above. Therefore there is no need to expose these parameters at the function level.

This change reduces a lot of duplicated code.

andikrueger avatar Jul 29 '22 19:07 andikrueger

Unfortunately these need to remain in there. I see your point, but the NEw-M365DSCReportFromConfiguration function does receive the ConfigurationPath parameter and simply passes it down to the 3 sub-functions (HTML, Excel and JSON) even if those are not being called directly.

NikCharlebois avatar Aug 22 '22 16:08 NikCharlebois