Microsoft365DSC
Microsoft365DSC copied to clipboard
Issue 2158
Pull Request (PR) description
Refactoring of the reporting functions
Fixes #2158
Those functions are internal and should not be called directly IMHO. All three functions are called by ‘ New-M365DSCReportFromConfiguration’. This function handles the changes above. Therefore there is no need to expose these parameters at the function level.
This change reduces a lot of duplicated code.
Unfortunately these need to remain in there. I see your point, but the NEw-M365DSCReportFromConfiguration function does receive the ConfigurationPath parameter and simply passes it down to the 3 sub-functions (HTML, Excel and JSON) even if those are not being called directly.