Microsoft365DSC icon indicating copy to clipboard operation
Microsoft365DSC copied to clipboard

Add possibility to manage Loop settings

Open ykuijs opened this issue 2 years ago • 1 comments

Details of the scenario you tried and the problem that is occurring

Recently, the opportunity to manage Loop settings via PowerShell has been added. These settings need to get added to M365DSC as well.

Announcement (look for "New Admin PowerShell control for Loop components"): https://techcommunity.microsoft.com/t5/microsoft-sharepoint-blog/sharepoint-roadmap-pitstop-may-2022/ba-p/3468499 Manage Loop components in SharePoint: https://docs.microsoft.com/en-us/sharepoint/manage-loop-components

Suggested solution to the issue

A new resource might be a good idea, but since the settings are added to the Get-SPOTenant cmdlet, maybe the SPOTenantSettings resource is also a good idea. In this last case: Maybe we have to connect with the PnP team to see if they plan to add these settings to Get-PnPTenant as well.

ykuijs avatar Jun 10 '22 07:06 ykuijs

This is currently not supported as part of PnP (Get-PnpTenant). Let's revisit once this property is added. https://github.com/pnp/powershell/issues/2189

NikCharlebois avatar Jul 22 '22 19:07 NikCharlebois

~This is already part of the PnP PowerShell since Sept. 2022. We should be good to go.~

Update: there is a difference between the PnP PowerShell and the SPO PowerShell

Settingname PnP PowerShell SPO PowerShell
isLoopEnabled x -
OneDriveLoopSharingCapability - x
OneDriveLoopDefaultSharingLinkScope - x
OneDriveLoopDefaultSharingLinkRole - x
CoreLoopSharingCapability - x
CoreLoopDefaultSharingLinkScope - x
CoreLoopDefaultSharingLinkRole - x

andikrueger avatar Apr 05 '23 07:04 andikrueger

Created a new request: https://github.com/pnp/powershell/issues/2975

andikrueger avatar Apr 05 '23 09:04 andikrueger

Looks like this may be a catch 21. We made a decision a few years back to adopt PnP.PowerShell over SPO PowerShell. On top of this, the latest PnP.PowerShell module v2.1.* only works for PowerShell 7 and we need to ensure support for both 5 and 7.

NikCharlebois avatar Apr 14 '23 11:04 NikCharlebois

This is something I feared... Basically, we are not able to introduce these changes, as this would break our support for PS 5.1 and we would have to wait for the October release. The other issue at hand is that DSC works best on PS 5.1....

Is there any chance to provide a custom M365DSCPnPPower(S)Hell Version or are these settings somehow exposed by MSGraph?

andikrueger avatar Apr 14 '23 12:04 andikrueger

The recommendation here would be for us to wait for these SPO Admin APIs to be available on Graph.

NikCharlebois avatar Apr 21 '23 19:04 NikCharlebois