MSBuildLocator icon indicating copy to clipboard operation
MSBuildLocator copied to clipboard

List of Breaking/Planned changes for MSBuild.Locator v2.0

Open YuliiaKovalova opened this issue 1 year ago • 1 comments

  1. Remove extra property AllowQueryAllRuntimeVersions. AllowAllRuntimeVersions from VisualStudioInstanceQueryOptions.cs means the same, but can't clean up immediately due to backward compatibility.
  2. There is a request to add a warning message about the possible compatibility issues - sometimes MSBuild that is being loaded is just too old to have modern things. https://github.com/microsoft/MSBuildLocator/issues/272 & https://github.com/microsoft/MSBuildLocator/issues/130 Change API to...
class MSBuildLocationResult
{
  public bool IsCompatibleWithCurrentRuntime;
  public MSBuildLocatorWarning[] Warnings;
  public string RootPath;
  public MSBuildDiscoveryType Context;

  public Version Version;
  public Architecture Architecture; 


  public void Register() {}
}
  1. https://github.com/dotnet/msbuild/issues/8166 - compatibility warning
  2. https://github.com/microsoft/MSBuildLocator/issues/254 - can be also a part of compatibility warning section
  3. https://github.com/microsoft/MSBuildLocator/issues/83 - find the way to implement this
  4. Add handling for the case described here: https://github.com/dotnet/msbuild/issues/9869#issuecomment-2007817375
  5. Handle the case for the versions clash: https://github.com/dotnet/msbuild/issues/10228
  6. Improve the error message for sdk resolution: https://github.com/microsoft/MSBuildLocator/issues/331

YuliiaKovalova avatar Feb 26 '24 09:02 YuliiaKovalova

After reading what you wrote above, I added a Version field to the result, which may actually supersede some of the warning stuff.

rainersigwald avatar Feb 26 '24 15:02 rainersigwald