MSBuildLocator icon indicating copy to clipboard operation
MSBuildLocator copied to clipboard

Add some guardrails to MSBuild Locator

Open YuliiaKovalova opened this issue 2 years ago • 2 comments

Add guardrails that can notify a customer that some of the deployed assemblies in a project can break MSBuild stuff.

YuliiaKovalova avatar Oct 26 '23 13:10 YuliiaKovalova

This would be beyond the "check for explicit MSBuild package references" we have:

https://github.com/microsoft/MSBuildLocator/blob/1c7a1092bec4b57c37a2f54e8db091073724c342/src/MSBuildLocator/build/Microsoft.Build.Locator.targets#L4-L21

We'd want something like a list of assemblies that shouldn't be deployed next to the final application, because they're expected to be found from the MSBuild installation.

rainersigwald avatar Oct 26 '23 15:10 rainersigwald

+1 to searching actual assemblies being deployed rather than looking at PackageReference items. Problematic assemblies like these (or System.CodeDom.dll) can be deployed without any PackageReference, including by transitive dependency.

AArnott avatar Oct 26 '23 17:10 AArnott