ML-For-Beginners icon indicating copy to clipboard operation
ML-For-Beginners copied to clipboard

My Instagram account i have forgotten all details about it

Open Okike7777 opened this issue 1 year ago • 5 comments

Describe the bug A clear and concise description of what the bug is.

To Reproduce Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior A clear and concise description of what you expected to happen.

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Additional context Add any other context about the problem here.

### Tasks
- [ ] https://github.com/microsoft/ML-For-Beginners/pull/751
### Tasks

Okike7777 avatar Jun 23 '24 23:06 Okike7777

To keep this feature working as expected we need to add a few tests into: com.oracle.svm.test

The tests can be executed from similarly to the tests for class initialization.

vjovanov avatar Jun 17 '24 16:06 vjovanov

To keep this feature working as expected we need to add a few tests into: com.oracle.svm.test

The tests can be executed from similarly to the tests for class initialization.

I have added a test task agenttest. It now only checks the premain method, doesn't do any class transformation yet.

ziyilin avatar Jun 19 '24 08:06 ziyilin

We need to add the CHANGELOG.md entry that claims that this is an experimental feature for now.

vjovanov avatar Jul 22 '24 11:07 vjovanov

We need to add the CHANGELOG.md entry that claims that this is an experimental feature for now.

Not sure which version and the internal code, I added the entry at the top of the CHANGELOG.md.

ziyilin avatar Jul 23 '24 02:07 ziyilin

This PR makes a good foundation for the agent support. After the final changes I will run all the tests, polish the CHANGELOG.md entry, and start with merging.

vjovanov avatar Aug 02 '24 09:08 vjovanov

@vjovanov will you merge this PR soon?

cemo avatar Sep 09 '24 11:09 cemo

The PR is in the queue and should be merged soon. We will also have follow-up PRs that push this feature forward.

vjovanov avatar Sep 10 '24 17:09 vjovanov

Merged: https://github.com/oracle/graal/commit/f16e655d85a2e541e0fc25d782ac6605709f4a28

Thank you @ziyilin!

vjovanov avatar Sep 11 '24 05:09 vjovanov