ML-For-Beginners icon indicating copy to clipboard operation
ML-For-Beginners copied to clipboard

updated lineplot() arguments

Open Ramin-RX7 opened this issue 2 years ago • 3 comments

These are just small changes for updated packages:

In commit 1d9d018:

  • Latest version of seaborn package where it is supported to pass x and y as arguments for lineplot() (positional) is v0.10 (link) . Since version 0.11 (latest is 0.12) lineplot() takes x and y only as keyword argument (and also the new parameter data) is added

In commit d01ebf4:

  • There is an unused enumerate() which is removed to make code cleaner and easier to read also n_classifiers variable has no use and it's unnecessary to declare/define.

In commit f471710:

  • as in Seaborn docs FacetGrid, Does not have any argument named size. Instead of size you should use height and aspect

In commit 327afbc:

  • The same issue with lineplot() in 1d9d018
  • Small fixes to text and codes

In commit 8c1ef29:

  • Using f-strings instead of using + operator
  • using name of variables in output instead of the whole string content, so it'll be easier to read

Ramin-RX7 avatar Jan 28 '23 18:01 Ramin-RX7

جميل

mag122ed avatar Apr 01 '23 04:04 mag122ed

This PR has not seen any action for a while! Closing for now, but it can be reopened at a later date.

github-actions[bot] avatar May 31 '23 08:05 github-actions[bot]

@carlotta94c @gdequeiroz I think it would be good if you guys take a look at this after 4 month

Ramin-RX7 avatar May 31 '23 19:05 Ramin-RX7

This PR has not seen any action for a while! Closing for now, but it can be reopened at a later date.

github-actions[bot] avatar Jul 31 '23 08:07 github-actions[bot]