Bugfix: fix index of numeric_feature_map_ in AddFeaturesFrom

[EdmondElephant]

Fix this issue: https://github.com/microsoft/LightGBM/issues/5410

[guolinke]

@EdmondElephant do you have time to add a simple test as @jameslamb suggests? We can help you to add the test if you are busy.

[StrikerRUS]

Kindly ping @EdmondElephant

[jameslamb]

@EdmondElephant Are you still interested in pursuing this?

If you tell us you are too busy, or don't respond in the next 2 weeks or so, I'll close this PR and open a new one with the changes + the request test.

You could also add me to the collaborators on your fork of LightGBM, so that I could push changes directly to this PR.

Thanks again for your help with LightGBM!

[EdmondElephant]

@jameslamb Sorry I'm a newbie to github and open-source projects, (and a bit busy...). I've tried to add you to the collaborators, please help add the request test and go ahead.

[jameslamb]

Sorry for the long delay. I'm ready to help get this merged. I received + accepted the invitation to your fork, and am able to push to it. Thanks for that!

I'll update this to latest master and push a unit test some time in the next few days, then ask other maintainers to help with reviews.

[jameslamb]

/gha run r-valgrind

Workflow R valgrind tests has been triggered! 🚀 https://github.com/microsoft/LightGBM/actions/runs/3231319391

Status: success ✔️.

[jameslamb]

I just pushed https://github.com/microsoft/LightGBM/pull/5434/commits/7e32261db0ae075df25495ecead6d9da7afbeee8, adding a unit test.

That test segfaults on master and passes on this branch.

Since I now have a commit on this PR, my approval shouldn't count towards a merge. I'm going to dismiss my review, and wait for another maintainer to review.

[jameslamb]

@EdmondElephant can you please add a comment here like this?

@microsoft-github-policy-service agree

Sorry, but it seems that Microsoft may have recently changed the way that it asks contributors to sign a Contributor License Agreement (CLA)

[jameslamb]

@EdmondElephant are you interested in continuing this contribution?

If so, please leave a comment agreeing to the CLA (https://github.com/microsoft/LightGBM/pull/5434#issuecomment-1275518491).

After you've done that, I can update this branch to latest master and merge it.

If we don't hear from you in the next two weeks, I'll close this and open a new pull request with these changes (preserving your commit so you'll still get credit as a contributor).

[jameslamb]

It's been a few months since we asked for the CLA to be signed. I'm closing this, and have replaced it with #5650.

preserving your commit so you'll still get credit as a contributor

I take this back. Since you haven't signed the CLA, I didn't include your commits in #5650. I don't think Microsoft's policies commits from authors who haven't signed the CLA to be merged in here.

---

Thanks very much for discovering, investigating, and fixing this bug! I hope you'll consider contributing to LightGBM again in the future when you have the time to work with us.

[github-actions[bot]]

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.