FluidFramework
FluidFramework copied to clipboard
Fix reupload blob if expired.
Reuploading an expired blob with the original localId caused a bug using blob placeholder approach since we remove pending blobs that are both acked and attached. So when we retry to upload the blob, it was already deleted since we're attached from the beginning in placeholder approach.
I believe maybe trying to reupload with the same localId was a bug since the beginning but in any case, reuploading with a clean localId seems a more reasonable approach. In case of blob expiration, we reupload the blob with a new localId, and fake an attach for the previous one so it gets removed once its op is processed.
Given this solution a closer look, using a new localId is not enough since we never track it in the original handle. We need to do a smarter mapping.
This PR has been automatically marked as stale because it has had no activity for 60 days. It will be closed if no further activity occurs within 8 days of this comment. Thank you for your contributions to Fluid Framework!