Remove back-compat code related to the op reentry checks

[MarioJGMsoft]

Fixes: AB#2309

Description

In light of Remove ability to reject reentrant ops (#20621) · microsoft/FluidFramework@c9d1562 (github.com), updating this to be about finishing the removal of ensureNoDataModelChanges.

Search the code for to be removed in 2.0 and you'll find these four results. They should be removed -- but two of them can't be removed until we open up 2.x releases for legacy/alpha-breaking changes:

4 results - 4 files

packages\runtime\container-runtime\src\channelCollection.ts: 171 }, 172: // back-compat, to be removed in 2.0 173 ensureNoDataModelChanges: (...args) => {

packages\runtime\container-runtime\src\dataStoreContext.ts: 225 226: // back-compat, to be removed in 2.0 227 public ensureNoDataModelChanges(callback: () => T): T {

packages\runtime\runtime-definitions\src\dataStoreContext.ts: 461 * @deprecated 462: * // back-compat: to be removed in 2.0 463 */

packages\runtime\test-runtime-utils\src\mocksDataStoreContext.ts: 98 99: // back-compat: to be removed in 2.0 100 public ensureNoDataModelChanges(callback: () => T): T {

[msfluid-bot]

⯆ @fluid-example/bundle-size-tests: -347 Bytes

Metric Name	Baseline Size	Compare Size	Size Diff
aqueduct.js	465.86 KB	465.75 KB	⯆ -113 Bytes
azureClient.js	563.18 KB	563.09 KB	⯆ -99 Bytes
connectionState.js	724 Bytes	724 Bytes	■ No change
containerRuntime.js	262.48 KB	262.35 KB	⯆ -134 Bytes
fluidFramework.js	426.99 KB	427.01 KB	⯅ +14 Bytes
loader.js	134.18 KB	134.19 KB	⯅ +14 Bytes
map.js	42.71 KB	42.71 KB	⯅ +7 Bytes
matrix.js	149.84 KB	149.85 KB	⯅ +7 Bytes
odspClient.js	528.97 KB	528.88 KB	⯆ -99 Bytes
odspDriver.js	97.88 KB	97.9 KB	⯅ +21 Bytes
odspPrefetchSnapshot.js	42.81 KB	42.83 KB	⯅ +14 Bytes
sharedString.js	165.77 KB	165.78 KB	⯅ +7 Bytes
sharedTree.js	417.45 KB	417.46 KB	⯅ +7 Bytes
Total Size	3.37 MB	3.37 MB	⯆ -347 Bytes

---

Baseline commit: 952e805137e6974280f865fb6924ca4caf46ff8b

Generated by :no_entry_sign: dangerJS against 5a45ae4a6641654e2f0e78643f31ab3abc01fb0d

[jason-ha]

I think PR description should be updated. It seems to reference past things rather than describe the current change. Probably should be similar to the changeset content.

[jatgarg]

@MarioJGMsoft Since @jason-ha suggested we can remove the test runtime utils one too in this PR, lets remove that as well. Also update the changeset accordingly.

[github-actions[bot]]

🔗 No broken links found! ✅

Your attention to detail is admirable.

linkcheck output

> [email protected] ci:linkcheck /home/runner/work/FluidFramework/FluidFramework/docs
> start-server-and-test ci:start 1313 linkcheck:full

1: starting server using command "npm run ci:start"
and when url "[ 'http://127.0.0.1:1313' ]" is responding with HTTP status code 200
running tests using command "npm run linkcheck:full"


> [email protected] ci:start
> http-server ./public --port 1313 --silent


> [email protected] linkcheck:full
> npm run linkcheck:fast -- --external


> [email protected] linkcheck:fast
> linkcheck http://localhost:1313 --skip-file skipped-urls.txt --external

Crawling...

Stats:
  443760 links
    3414 destination URLs
       2 URLs ignored
       0 warnings
       0 errors