FluidFramework icon indicating copy to clipboard operation
FluidFramework copied to clipboard

Remove WRITE usages of compatDetails on ContainerRuntime GC ops

Open MarioJGMsoft opened this issue 1 year ago • 1 comments

Description

Fixes: AB#19718

Follow-on to #17024

We need to look at Kusto first to confirm our theory that the code to read both the GC op types ("Sweep" and "TombstoneLoaded") has sufficiently saturated. "Sweep" was added in 2.0.0-internal.7.4.0 "TombstoneLoaded" was added in 2.0.0-rc.2.0.0 We do see sessions on RC.1, but I believe they're all Whiteboard, which doesn't see any "TombstoneLoaded" events which trigger those ops.

We can write a query to confirm with high confidence, then proceed.

Reviewer Guidance

The goal of this PR is to remove all uses of compatDetails that are no longer necessary, please let me know if I missed any or if there are some that can't be removed yet.

MarioJGMsoft avatar Oct 14 '24 18:10 MarioJGMsoft

@fluid-example/bundle-size-tests: -503 Bytes
Metric NameBaseline SizeCompare SizeSize Diff
aqueduct.js 467.26 KB 467.11 KB -152 Bytes
azureClient.js 564.03 KB 563.9 KB -138 Bytes
connectionState.js 724 Bytes 724 Bytes No change
containerRuntime.js 263.45 KB 263.29 KB -173 Bytes
fluidFramework.js 429.04 KB 429.05 KB +14 Bytes
loader.js 134.18 KB 134.19 KB +14 Bytes
map.js 42.71 KB 42.71 KB +7 Bytes
matrix.js 150.15 KB 150.16 KB +7 Bytes
odspClient.js 530.39 KB 530.26 KB -138 Bytes
odspDriver.js 98.41 KB 98.43 KB +21 Bytes
odspPrefetchSnapshot.js 42.81 KB 42.83 KB +14 Bytes
sharedString.js 166.23 KB 166.24 KB +7 Bytes
sharedTree.js 419.49 KB 419.5 KB +7 Bytes
Total Size 3.38 MB 3.38 MB -503 Bytes

Baseline commit: c025b53f3b007117c0338f3badb34d14b6175f92

Generated by :no_entry_sign: dangerJS against 9a044dbb20b903fbc98927c82cea4cd8a5afa253

msfluid-bot avatar Oct 15 '24 17:10 msfluid-bot