ContainerRuntime: Remove the contents property of batchBegin/batchEnd's "op" event arg
Description
Fixes AB#19784
ContainerRuntime's 'batchBegin'/'batchEnd' events: Removing the contents property on event arg op
The 'batchBegin'/'batchEnd' events on ContainerRuntime indicate when a batch is beginning/finishing being processed.
The contents property on there is not useful or relevant when reasoning over incoming changes at the batch level.
So it has been removed from the op event arg.
Breaking Changes
Yes this is a breaking change. See changeset.
Converting to Draft until main is open for breaking changes
I'll be OOF until 11/14. I'll plan to bring this in for 2.10.0 at that point if it's not too late (unless someone decides to merge this for me while I'm OOF)
⯅ @fluid-example/bundle-size-tests: +233 Bytes
| Metric Name | Baseline Size | Compare Size | Size Diff |
|---|---|---|---|
| aqueduct.js | 464.03 KB | 464.06 KB | ⯅ +32 Bytes |
| azureClient.js | 562.45 KB | 562.49 KB | ⯅ +46 Bytes |
| connectionState.js | 724 Bytes | 724 Bytes | ■ No change |
| containerRuntime.js | 261.86 KB | 261.87 KB | ⯅ +11 Bytes |
| fluidFramework.js | 424.82 KB | 424.84 KB | ⯅ +14 Bytes |
| loader.js | 134.17 KB | 134.19 KB | ⯅ +14 Bytes |
| map.js | 42.71 KB | 42.71 KB | ⯅ +7 Bytes |
| matrix.js | 148.54 KB | 148.55 KB | ⯅ +7 Bytes |
| odspClient.js | 528.3 KB | 528.34 KB | ⯅ +46 Bytes |
| odspDriver.js | 97.84 KB | 97.86 KB | ⯅ +21 Bytes |
| odspPrefetchSnapshot.js | 42.81 KB | 42.83 KB | ⯅ +14 Bytes |
| sharedString.js | 164.58 KB | 164.58 KB | ⯅ +7 Bytes |
| sharedTree.js | 415.28 KB | 415.29 KB | ⯅ +7 Bytes |
| Total Size | 3.36 MB | 3.36 MB | ⯅ +233 Bytes |
Baseline commit: 2aa0b5e7941efe52386782595f96ff847c786fc3
Generated by :no_entry_sign: dangerJS against 5738a9baa78123d5cc1fe29fd57ce492e60bc61d
@kian-thompson feel free to merge this if the time is right for breaking changes. Not paying attention broadly, just saw the notification that you approved it.
🔗 No broken links found! ✅
Your attention to detail is admirable.
linkcheck output
> [email protected] ci:linkcheck /home/runner/work/FluidFramework/FluidFramework/docs
> start-server-and-test ci:start 1313 linkcheck:full
1: starting server using command "npm run ci:start"
and when url "[ 'http://127.0.0.1:1313' ]" is responding with HTTP status code 200
running tests using command "npm run linkcheck:full"
> [email protected] ci:start
> http-server ./public --port 1313 --silent
> [email protected] linkcheck:full
> npm run linkcheck:fast -- --external
> [email protected] linkcheck:fast
> linkcheck http://localhost:1313 --skip-file skipped-urls.txt --external
Crawling...
Stats:
447786 links
3441 destination URLs
2 URLs ignored
0 warnings
0 errors