FluidFramework icon indicating copy to clipboard operation
FluidFramework copied to clipboard

Any code cleanup for task related to MIP label updates for odsp driver.

Open MarioJGMsoft opened this issue 1 year ago • 2 comments

Description

As mentioned in the comment here: https://github.com/microsoft/FluidFramework/pull/19142#discussion_r1445266736 Make the sensitivityLabelsInfo on join session response non optional once new service code which provides this in the response saturates.

This task also tracks any other code cleanup related to this feature like always listening on doc service once we have the driver version saturation.

In order to maintain back compat, we listen to events on IDocumentService by checking whether we expose on/off on the service object due to back compat. Ex: // Back-compat for Old driver if (service.on !== undefined) { service.on("metadataUpdate", this.metadataUpdateHandler); }

I think we can check if we can remove that check before registering/unregistering events listeners. We need to see if the loader version which listens this event does not use a driver version which does not emit IDocumentServiceEvents. Kusto will help us with this.

Fixes item: AB#6877

MarioJGMsoft avatar Oct 07 '24 18:10 MarioJGMsoft

🔗 No broken links found! ✅

Your attention to detail is admirable.

linkcheck output


> [email protected] ci:linkcheck /home/runner/work/FluidFramework/FluidFramework/docs
> start-server-and-test ci:start 1313 linkcheck:full

1: starting server using command "npm run ci:start"
and when url "[ 'http://127.0.0.1:1313' ]" is responding with HTTP status code 200
running tests using command "npm run linkcheck:full"


> [email protected] ci:start
> http-server ./public --port 1313 --silent


> [email protected] linkcheck:full
> npm run linkcheck:fast -- --external


> [email protected] linkcheck:fast
> linkcheck http://localhost:1313 --skip-file skipped-urls.txt --external

Crawling...

Stats:
  428360 links
    3310 destination URLs
       2 URLs ignored
       0 warnings
       0 errors


github-actions[bot] avatar Oct 09 '24 22:10 github-actions[bot]

@fluid-example/bundle-size-tests: +230 Bytes
Metric NameBaseline SizeCompare SizeSize Diff
aqueduct.js 459.88 KB 459.92 KB +35 Bytes
azureClient.js 556.87 KB 556.9 KB +34 Bytes
connectionState.js 724 Bytes 724 Bytes No change
containerRuntime.js 259.16 KB 259.17 KB +14 Bytes
fluidFramework.js 406.05 KB 406.06 KB +14 Bytes
loader.js 134.34 KB 134.36 KB +14 Bytes
map.js 42.46 KB 42.46 KB +7 Bytes
matrix.js 148.63 KB 148.64 KB +7 Bytes
odspClient.js 523.83 KB 523.88 KB +49 Bytes
odspDriver.js 97.84 KB 97.86 KB +21 Bytes
odspPrefetchSnapshot.js 42.81 KB 42.82 KB +14 Bytes
sharedString.js 164.82 KB 164.83 KB +7 Bytes
sharedTree.js 396.51 KB 396.51 KB +7 Bytes
Total Size 3.31 MB 3.31 MB +230 Bytes

Baseline commit: 0e3abe80bed6b79ab155cbb5b1aef1f6e3d0c2da

Generated by :no_entry_sign: dangerJS against 7bd83b79e982acd43fbb5d6610cfe8aa1b2c69a2

msfluid-bot avatar Oct 11 '24 19:10 msfluid-bot

This PR has been automatically marked as stale because it has had no activity for 60 days. It will be closed if no further activity occurs within 8 days of this comment. Thank you for your contributions to Fluid Framework!