FluidFramework icon indicating copy to clipboard operation
FluidFramework copied to clipboard

Make DEFAULT_INTERDEPENDENCY_RANGE "workspace:~"

Open CraigMacomber opened this issue 1 year ago • 2 comments

Description

flub bump has two use cases:

  1. Setting the dependency versions during release via tools/pipelines/templates/include-set-package-version.yml which uses update-package-version.sh. This case sets --interdependencyRange unconditionally and should not be impacted by the default.
  2. running flub bump to update the version for releases (usually via flub release). This wants to leave the dependencies unchanged.

Since dependencies in main use "workspace:~", this second case has been making unwanted modifications when trying to just bump the version.

Future changes should separate these two use cases into a tool that bumps versions and a tool which sets the inter dependency ranges.

While evaluating use of DEFAULT_INTERDEPENDENCY_RANGE, bumpReleaseGroup which uses it was found, but is dead code and was deleted.

DEFAULT_INTERDEPENDENCY_RANGE was then moved next to its only remaining use getDefaultInterdependencyRange.

Breaking Changes

Anything that relies on the current getDefaultInterdependencyRange will be impacted.

Since that is a InterdependencyRange meaning it only applies to "dependencies between packages within the same release group." this change seems like it's an improvement.

The only other user of getDefaultInterdependencyRange is doReleaseGroupBump, which seems like it should fix previously unknown issue where it has the same issue, so this is likely fine.

Reviewer Guidance

The review process is outlined on this wiki page.

CraigMacomber avatar Sep 24 '24 21:09 CraigMacomber