microsoft
feat(build-cli): New command check:prApproval
Adds a new flub command, check:prApproval, which is used to check if a PR in the repo is approved by a GitHub team or list of users.
This command is then used in a new workflow that runs on release branch PRs to check that a member of the FluidFramework-ReleaseApprovers team has approved the PR. We'll then make that a required check for release branch PRs.
Finally, the CODEOWNERS file is updated to require approval from FluidFramework-ReleaseApprovers for changes to the workflow itself.
The command can be run locally with a GitHub PAT, which is how I tested. I also tested against a test branch on my fork. However, none of these tests is an exact analog to the real Actions environment.
Because of how Actions work, this workflow must be merged to main before it can be further tested using branches.
As currently configured, this would immediately begin to block changes on release branches, right?
No - the workflow has to be ported to a release branch to take effect. So the earliest it would "automatically" start would be after next release.
⯅ @fluid-example/bundle-size-tests: +245 Bytes
| Metric Name | Baseline Size | Compare Size | Size Diff |
|---|---|---|---|
| aqueduct.js | 459.92 KB | 459.95 KB | ⯅ +35 Bytes |
| azureClient.js | 557.96 KB | 558.01 KB | ⯅ +49 Bytes |
| connectionState.js | 680 Bytes | 680 Bytes | ■ No change |
| containerRuntime.js | 260.75 KB | 260.76 KB | ⯅ +14 Bytes |
| fluidFramework.js | 398.95 KB | 398.97 KB | ⯅ +14 Bytes |
| loader.js | 134.26 KB | 134.28 KB | ⯅ +14 Bytes |
| map.js | 42.39 KB | 42.39 KB | ⯅ +7 Bytes |
| matrix.js | 146.56 KB | 146.56 KB | ⯅ +7 Bytes |
| odspClient.js | 525.23 KB | 525.28 KB | ⯅ +49 Bytes |
| odspDriver.js | 97.72 KB | 97.74 KB | ⯅ +21 Bytes |
| odspPrefetchSnapshot.js | 42.78 KB | 42.79 KB | ⯅ +14 Bytes |
| sharedString.js | 163.26 KB | 163.26 KB | ⯅ +7 Bytes |
| sharedTree.js | 389.47 KB | 389.47 KB | ⯅ +7 Bytes |
| Total Size | 3.29 MB | 3.29 MB | ⯅ +245 Bytes |
Baseline commit: f4da8fc479448ae0e29a4d641353cd13f5c3b3cf
Generated by :no_entry_sign: dangerJS against f430555ef827375b4ad1c9c2b16bed25d1500fef
