FluidFramework icon indicating copy to clipboard operation
FluidFramework copied to clipboard

IFluidContainer.attach() test

Open vladsud opened this issue 1 year ago • 1 comments

This PR shows issue with IFluidContainer.attach signature. It should fail compilation, but it does not. It demonstrates that users have no clue what is allowed / supported in this flow. There is no way to find it (other than parsing code), and no way to enforce contract.

vladsud avatar Aug 06 '24 22:08 vladsud

@fluid-example/bundle-size-tests: +245 Bytes
Metric NameBaseline SizeCompare SizeSize Diff
aqueduct.js 457.4 KB 457.43 KB +35 Bytes
azureClient.js 554.57 KB 554.61 KB +49 Bytes
connectionState.js 680 Bytes 680 Bytes No change
containerRuntime.js 258.07 KB 258.08 KB +14 Bytes
fluidFramework.js 406.12 KB 406.13 KB +14 Bytes
loader.js 134.04 KB 134.05 KB +14 Bytes
map.js 42.13 KB 42.14 KB +7 Bytes
matrix.js 146.42 KB 146.42 KB +7 Bytes
odspClient.js 522.71 KB 522.76 KB +49 Bytes
odspDriver.js 97.55 KB 97.57 KB +21 Bytes
odspPrefetchSnapshot.js 42.61 KB 42.62 KB +14 Bytes
sharedString.js 163.14 KB 163.15 KB +7 Bytes
sharedTree.js 396.63 KB 396.64 KB +7 Bytes
Total Size 3.29 MB 3.3 MB +245 Bytes

Baseline commit: d27fd8b796dc1cb0cdce3fc71221b20d80e97e08

Generated by :no_entry_sign: dangerJS against 3b4cc83691ec9820de145204a0c8dcf8c6bb12f6

msfluid-bot avatar Aug 06 '24 23:08 msfluid-bot

This PR has been automatically marked as stale because it has had no activity for 60 days. It will be closed if no further activity occurs within 8 days of this comment. Thank you for your contributions to Fluid Framework!