FluidFramework icon indicating copy to clipboard operation
FluidFramework copied to clipboard

Deprecating forceAccessTokenViaAuthorizationHeader in odsp-driver

Open aboktor opened this issue 1 year ago • 2 comments

Description

There is an assumption throughout the odsp-driver code that tokens are always Bearer tokens. This is not the case. AT_POP tokens could also be used. AT_POP tokens encode url path, query params and http method into the token. This means that the token itself cannot be passed via query params (otherwise that would be a circular dependency). In preparation for more changes to come to support AT_POP tokens, this PR removes forceAccessTokenViaAuthorizationHeader.

Breaking Changes

None, however, the option passed via the interface to prefetchLatestSnapshot now has no effect.

Reviewer Guidance

  • How do I tag asserts?

aboktor avatar Jun 13 '24 16:06 aboktor

Talked to @vladsud and we might want to take a different approach where a PR like this one is merged only in main and we do a smaller set of changes in RC2. I will leave this PR up while I investigate that approach.

aboktor avatar Jun 13 '24 16:06 aboktor

Could not find a usable baseline build with search starting at CI dc4ad45b2e8224d3c04f397c37cf834fceba0e82

Generated by :no_entry_sign: dangerJS against a5a0000e287cd607a6f6b2f63ba1e78348c3c99d

msfluid-bot avatar Jun 13 '24 17:06 msfluid-bot

This PR has been automatically marked as stale because it has had no activity for 60 days. It will be closed if no further activity occurs within 8 days of this comment. Thank you for your contributions to Fluid Framework!