FluidFramework icon indicating copy to clipboard operation
FluidFramework copied to clipboard

Update client to pnpm 9

Open CraigMacomber opened this issue 1 year ago • 3 comments

Description

This is a test to see how CI handles pnpm 9.

It is expected that component detection will fail, not detect any client dependencies, but allow CI to pass anyway. This will confirm if that occurs.

Blocked on https://github.com/microsoft/component-detection/issues/1148

Reviewer Guidance

The review process is outlined on this wiki page.

CraigMacomber avatar Jun 06 '24 16:06 CraigMacomber

@fluid-example/bundle-size-tests: +245 Bytes
Metric NameBaseline SizeCompare SizeSize Diff
aqueduct.js 459.88 KB 459.92 KB +35 Bytes
azureClient.js 556.87 KB 556.91 KB +49 Bytes
connectionState.js 724 Bytes 724 Bytes No change
containerRuntime.js 259.16 KB 259.17 KB +14 Bytes
fluidFramework.js 406.05 KB 406.06 KB +14 Bytes
loader.js 134.34 KB 134.36 KB +14 Bytes
map.js 42.46 KB 42.46 KB +7 Bytes
matrix.js 148.63 KB 148.64 KB +7 Bytes
odspClient.js 523.83 KB 523.88 KB +49 Bytes
odspDriver.js 97.84 KB 97.86 KB +21 Bytes
odspPrefetchSnapshot.js 42.81 KB 42.82 KB +14 Bytes
sharedString.js 164.82 KB 164.83 KB +7 Bytes
sharedTree.js 396.51 KB 396.51 KB +7 Bytes
Total Size 3.31 MB 3.31 MB +245 Bytes

Baseline commit: 887a75ff76a5f7d855a7ddca5d66ca0b81f031ae

Generated by :no_entry_sign: dangerJS against 14edb2b927af4f55e4a53e7a1fd59517a3e90d31

msfluid-bot avatar Jun 06 '24 18:06 msfluid-bot

Confirmed to warn with "##[warning]Unsupported lockfileVersion in pnpm yaml file /mnt/vss/_work/1/s/pnpm-lock.yaml" but not fail.

Wait for https://github.com/microsoft/component-detection/issues/1148 before updating

CraigMacomber avatar Jun 07 '24 00:06 CraigMacomber

Still waiting for https://github.com/microsoft/component-detection/issues/1148

CraigMacomber avatar Oct 02 '24 19:10 CraigMacomber

🔗 No broken links found! ✅

Your attention to detail is admirable.

linkcheck output


> [email protected] ci:check-links /home/runner/work/FluidFramework/FluidFramework/docs
> start-server-and-test "npm run serve -- --no-open" 3000 check-links

1: starting server using command "npm run serve -- --no-open"
and when url "[ 'http://127.0.0.1:3000' ]" is responding with HTTP status code 200
running tests using command "npm run check-links"


> [email protected] serve
> docusaurus serve --no-open

[SUCCESS] Serving "build" directory at: http://localhost:3000/

> [email protected] check-links
> linkcheck http://localhost:3000 --skip-file skipped-urls.txt

Crawling...

Stats:
  170006 links
    1595 destination URLs
    1825 URLs ignored
       0 warnings
       0 errors


github-actions[bot] avatar Dec 13 '24 20:12 github-actions[bot]

Superseded by https://github.com/microsoft/FluidFramework/pull/21328

CraigMacomber avatar Jan 16 '25 17:01 CraigMacomber