FluidFramework icon indicating copy to clipboard operation
FluidFramework copied to clipboard

Remove extra calls to bind when not attached

Open jzaffiro opened this issue 1 year ago • 1 comments

With the change to the ordering of getting the attachment summary in #20998 and the testing in #20995 and #21132, we can now remove the workarounds that call bindHandles or makeSerializable when not in an attached state.

jzaffiro avatar May 23 '24 00:05 jzaffiro

Fixes AB#7316

markfields avatar May 23 '24 19:05 markfields

@fluid-example/bundle-size-tests: -115 Bytes
Metric NameBaseline SizeCompare SizeSize Diff
aqueduct.js 453.27 KB 453.25 KB -14 Bytes
azureClient.js 552.5 KB 552.49 KB -14 Bytes
connectionState.js 680 Bytes 680 Bytes No change
containerRuntime.js 256.95 KB 256.95 KB No change
fluidFramework.js 359.88 KB 359.88 KB No change
loader.js 134.38 KB 134.38 KB No change
map.js 41.53 KB 41.46 KB -73 Bytes
matrix.js 143.75 KB 143.75 KB No change
odspClient.js 520.87 KB 520.85 KB -14 Bytes
odspDriver.js 97.3 KB 97.3 KB No change
odspPrefetchSnapshot.js 42.16 KB 42.16 KB No change
sharedString.js 160.27 KB 160.27 KB No change
sharedTree.js 359.86 KB 359.86 KB No change
Total Size 3.2 MB 3.2 MB -115 Bytes

Baseline commit: 936f247c806745a2637cbc2fb69683e0b35136e9

Generated by :no_entry_sign: dangerJS against 6040a46c5be77095da3e6e375d039633111e5edc

msfluid-bot avatar May 28 '24 18:05 msfluid-bot