FluidFramework icon indicating copy to clipboard operation
FluidFramework copied to clipboard

rc1.0: Upload manifest file for release branch

Open sonalideshpandemsft opened this issue 1 year ago • 1 comments

Cherry-pick https://github.com/microsoft/FluidFramework/pull/21143 and https://github.com/microsoft/FluidFramework/pull/20722

sonalideshpandemsft avatar May 17 '24 23:05 sonalideshpandemsft

Could not find a usable baseline build with search starting at CI ff987dc30fdc2211c58f9b2ad21273e41e4b3a74

Generated by :no_entry_sign: dangerJS against 4530ed2057d71048b075037477a0d4a4eda040c2

msfluid-bot avatar May 18 '24 00:05 msfluid-bot

A test is failing for this PR, unlike the others.

sonalideshpandemsft avatar May 21 '24 23:05 sonalideshpandemsft

My suggestion would be to comment that test. We had the same issue when porting another change to the rc branches; some of build-tools' "unit tests" assume that some things haven't happened in the real world (like having published rc3) so when we run them again after that has happened, they will always fail. And since we won't be releasing build-tools from this release branch, it should be ok to not have the test.

alexvy86 avatar May 22 '24 15:05 alexvy86

My suggestion would be to comment that test. We had the same issue when porting another change to the rc branches; some of build-tools' "unit tests" assume that some things haven't happened in the real world (like having published rc3) so when we run them again after that has happened, they will always fail. And since we won't be releasing build-tools from this release branch, it should be ok to not have the test.

@alexvy86 @sonalideshpandemsft I was too slow for this PR, but what I would have recommended is using a newer version of build-tools in the pipeline. That's why we support running the pipeline using the in-repo version and a version installed from npm - so we can run pipelines on older or newer build-tools versions and don't have to maintain build-tools code on a release branch. If there's a bug in the new commands, the fix will have to be ported to each pipeline where the code lives. Better to be able to bump versions.

tylerbutler avatar May 22 '24 18:05 tylerbutler