FluidFramework icon indicating copy to clipboard operation
FluidFramework copied to clipboard

enable single commit summary via supportedFeatures in routerlicious

Open pragya91 opened this issue 1 year ago • 1 comments

Enable single-commit summaries via summarizeProtocolTree policy flag in IDocumentServicePolicies - which for routerlicious will be set when enable_single_commit_summary flag is provided in the supportedFeatures property bag in IConnected. This change is particularly aimed at enabling slow rollouts of FRS clients on the single-commit summary flow.

  1. updated routerlicious-driver's documentService to check the supported features and set the summarizeProtocolTree driver policy. Container uses this flag to check whether or not the protocol tree should be added to the summary before sending the summary.
  2. Updated containerStorageAdapter to always initialize ProtocolTreeStorageService.
  3. ProtocolTreeStorageService uses a callback to check whether it should upload protocoltree with summary or not. This is done to ensure we are using the most updated value of driver policy which will be set correctly only when the delta connection is established.
  4. Renamed forceEnableSummarizeProtocolTree to shouldSummarizeProtocolTree.

AB#7864

pragya91 avatar May 13 '24 18:05 pragya91

@fluid-example/bundle-size-tests: +563 Bytes
Metric NameBaseline SizeCompare SizeSize Diff
aqueduct.js 457.22 KB 457.22 KB No change
azureClient.js 558.24 KB 558.54 KB +307 Bytes
connectionState.js 680 Bytes 680 Bytes No change
containerRuntime.js 259.68 KB 259.68 KB No change
fluidFramework.js 364.98 KB 364.98 KB No change
loader.js 135.64 KB 135.76 KB +128 Bytes
map.js 39.83 KB 39.83 KB No change
matrix.js 142.48 KB 142.48 KB No change
odspClient.js 526.59 KB 526.71 KB +128 Bytes
odspDriver.js 98.29 KB 98.29 KB No change
odspPrefetchSnapshot.js 42.11 KB 42.11 KB No change
sharedString.js 159.28 KB 159.28 KB No change
sharedTree.js 364.97 KB 364.97 KB No change
Total Size 3.23 MB 3.23 MB +563 Bytes

Baseline commit: 1ac951f6eda44c59dcf5bb372bc9b93619619d47

Generated by :no_entry_sign: dangerJS against b15a42a58d4a9936deae916071fc7eb0c6ac02ae

msfluid-bot avatar May 13 '24 21:05 msfluid-bot