FluidFramework icon indicating copy to clipboard operation
FluidFramework copied to clipboard

Published 20 hours ago • verified publisher icon microsoft

Type Erase IFluidDataStoreRuntime.deltaManager

Open CraigMacomber opened this issue 1 year ago • 1 comments

Description

IFluidDataStoreRuntime.deltaManager is the only thing that requires several types toy be public:

Made Alpha in this PR:

  • IConnectionDetails
  • IDeltaSender
  • IDeltaManagerEvents
  • IDeltaManager
  • IDeltaQueueEvents
  • IDeltaQueue
  • ReadOnlyInfo

Can be make Alpha in a follow-up PR:

  • ITokenClaims
  • IDocumentMessage
  • IClientConfiguration
  • IAnyDriverError
  • IDriverErrorBase
  • DriverErrorTypes

Breaking Changes

The following types have been moved from @public to @alpha:

  • IConnectionDetails
  • IDeltaSender
  • IDeltaManagerEvents
  • IDeltaManager
  • IDeltaQueueEvents
  • IDeltaQueue
  • ReadOnlyInfo

IFluidDataStoreRuntime.deltaManager has been replaced with IFluidDataStoreRuntime.deltaManagerErased which requires access to the @alpha toDeltaManagerInternal to retrieve its members.

Reviewer Guidance

The review process is outlined on this wiki page.

TODO:

  • [ ] Get design reviewed/approved
  • [ ] add change-set
  • [ ] fix webpack errors (cause unknown)

Tracked by internal item: https://dev.azure.com/fluidframework/internal/_workitems/edit/6602

CraigMacomber avatar May 06 '24 23:05 CraigMacomber

The strange webpack issue should be resolved, so I expect this to pass CI now.

CraigMacomber avatar May 08 '24 03:05 CraigMacomber

Baseline CI build failed, cannot generate bundle analysis at this time

Baseline commit: ba7fe216bd3b1c10d0a6cb9216510e29c80b8e2c

Generated by :no_entry_sign: dangerJS against 549f8c05684514392c12f0ef0183d47bc7678118

msfluid-bot avatar May 08 '24 17:05 msfluid-bot