feat(check:policy): New policy to check and sort tsconfig files in the repo

[tylerbutler]

Adds a new policy handler to check and sort tsconfig files based on an order we define. Comments in the tsconfig files should be maintained, and the resolver should output files formatted according to their prettier settings.

Problem: To check if a file is sorted, I load it and sort it, then compare it to the original (in a normalized way). This is slow. If you have ideas for speeding up the isSorted check let me know.

I ran the new handler on the build-tools folder manually and included those changes here.

[jason-ha]

Which part is slow? The sort or the compare? (Others are sort of fixed.) Is there no existing utility to do this? If the sort or compare is slow you could try hashing and caching.

[tylerbutler]

Which part is slow? The sort or the compare? (Others are sort of fixed.)

Is there no existing utility to do this?

If the sort or compare is slow you could try hashing and caching.

Haven't dug into it at that level but I think it's the sort. The compare is just a string equality check. But there's also looking up the prettier config and reformatting, which could be a big chunk of the time.

I could try normalizing with a fixed config instead of looking it up, and then reformat using the config settings only if needed. But still I think the sort itself is the expensive part.

[jason-ha]

Which part is slow? The sort or the compare? (Others are sort of fixed.) Is there no existing utility to do this? If the sort or compare is slow you could try hashing and caching.

Haven't dug into it at that level but I think it's the sort. The compare is just a string equality check. But there's also looking up the prettier config and reformatting, which could be a big chunk of the time.

I could try normalizing with a fixed config instead of looking it up, and then reformat using the config settings only if needed. But still I think the sort itself is the expensive part.

I see that the sort is also prettification. I think the best option is probably to check if sorted rather than to sort and format and compare. Reading and checking order could be pretty fast. This could be custom here until sort-jsonc is updated with a new feature. :) Logic is pretty simple. Steal the compare by array order from sort-jsonc. At each level of object make sure comparison is always higher for each new entry read (iteratively).

[tylerbutler]

Which part is slow? The sort or the compare? (Others are sort of fixed.)

Is there no existing utility to do this?

If the sort or compare is slow you could try hashing and caching.

Haven't dug into it at that level but I think it's the sort. The compare is just a string equality check. But there's also looking up the prettier config and reformatting, which could be a big chunk of the time.

I could try normalizing with a fixed config instead of looking it up, and then reformat using the config settings only if needed. But still I think the sort itself is the expensive part.

I see that the sort is also prettification. I think the best option is probably to check if sorted rather than to sort and format and compare. Reading and checking order could be pretty fast. This could be custom here until sort-jsonc is updated with a new feature. :)

Logic is pretty simple. Steal the compare by array order from sort-jsonc. At each level of object make sure comparison is always higher for each new entry read (iteratively).

To be clear, are you suggesting I re implement most of the sort? I'd prefer not to implement anything like that. IMO if it's not simple enough to plug something in to do it, it's not worth the dev and maintenance cost. That is, I don't want to maintain code that checks if tsconfigs are sorted (vs plugging in code maintained elsewhere to do it).

If I were to implement this I think I would do it in sort-jsonc, adding a check option with an early exit in the sort.

[tylerbutler]

Which part is slow? The sort or the compare? (Others are sort of fixed.)

Is there no existing utility to do this?

If the sort or compare is slow you could try hashing and caching.

Haven't dug into it at that level but I think it's the sort. The compare is just a string equality check. But there's also looking up the prettier config and reformatting, which could be a big chunk of the time.

I could try normalizing with a fixed config instead of looking it up, and then reformat using the config settings only if needed. But still I think the sort itself is the expensive part.

I see that the sort is also prettification. I think the best option is probably to check if sorted rather than to sort and format and compare. Reading and checking order could be pretty fast. This could be custom here until sort-jsonc is updated with a new feature. :) Logic is pretty simple. Steal the compare by array order from sort-jsonc. At each level of object make sure comparison is always higher for each new entry read (iteratively).

To be clear, are you suggesting I re implement most of the sort? I'd prefer not to implement anything like that. IMO if it's not simple enough to plug something in to do it, it's not worth the dev and maintenance cost. That is, I don't want to maintain code that checks if tsconfigs are sorted (vs plugging in code maintained elsewhere to do it).

If I were to implement this I think I would do it in sort-jsonc, adding a check option with an early exit in the sort.

I opened https://github.com/duniul/sort-jsonc/issues/6; might implement it myself if the maintainer is open to it.

[jason-ha]

To be clear, are you suggesting I re implement most of the sort? I'd prefer not to implement anything like that. IMO if it's not simple enough to plug something in to do it, it's not worth the dev and maintenance cost. That is, I don't want to maintain code that checks if tsconfigs are sorted (vs plugging in code maintained elsewhere to do it). If I were to implement this I think I would do it in sort-jsonc, adding a check option with an early exit in the sort.

I opened duniul/sort-jsonc#6; might implement it myself if the maintainer is open to it.

I was not suggesting implementation of the sort. It is one thing to check and another to sort. Checking if sorted is efficient with simple in-order walk. Actual sorting is not usually efficient walking in-order. Efficient sorting may also not lend its hand to an is sorted check add-on. Just my thoughts on the posed performance topic.

[microsoft-github-policy-service[bot]]

This PR has been automatically marked as stale because it has had no activity for 60 days. It will be closed if no further activity occurs within 8 days of this comment. Thank you for your contributions to Fluid Framework!