FluidFramework
FluidFramework copied to clipboard
microsoft
Half fix factory
Description
Experiment showing how the requirement that factories are classes could be lifted.
Breaking Changes
...
Reviewer Guidance
The review process is outlined on this wiki page.
FYI - @anthony-murphy and/or @ChumpChief have expressed interest in this improving this area in the past.
It should be working now. A lot of these changes can be pulling into a separate PR (ex: using the interfaces instead of concreate types when practical). Once that's been done, this PR will be more carefully evaluated and have its breaking changes documented.
⯆ @fluid-example/bundle-size-tests: -91 Bytes
| Metric Name | Baseline Size | Compare Size | Size Diff |
|---|---|---|---|
| aqueduct.js | 516.3 KB | 516.23 KB | ⯆ -78 Bytes |
| connectionState.js | 680 Bytes | 680 Bytes | ■ No change |
| containerRuntime.js | 249.82 KB | 249.82 KB | ■ No change |
| loader.js | 128.1 KB | 128.1 KB | ■ No change |
| map.js | 41.38 KB | 41.36 KB | ⯆ -13 Bytes |
| matrix.js | 143.87 KB | 143.87 KB | ■ No change |
| odspDriver.js | 97.23 KB | 97.23 KB | ■ No change |
| odspPrefetchSnapshot.js | 41.91 KB | 41.91 KB | ■ No change |
| sharedString.js | 161.73 KB | 161.73 KB | ■ No change |
| sharedTree.js | 330.73 KB | 330.73 KB | ■ No change |
| Total Size | 1.82 MB | 1.82 MB | ⯆ -91 Bytes |
Baseline commit: d7d712ca0f70d9f21cc6b19d3bc3bd523290a1eb
Generated by :no_entry_sign: dangerJS against e90b7acb2ae646486d34136e9e1e80ded6674c7b
