FluidFramework
FluidFramework copied to clipboard
fix(build-tools): mixed internal range detection
better inspect complex ranges with || handle cross prerelease rejection in single range set
refactor tests to see examples in table form
My only concern is if test-version-utils in the client release group is expecting ^2.0.0-internal.1.0.0 to be identified as internal. Haven't had time to check myself. Everything else looks good.
My only concern is if test-version-utils in the client release group is expecting ^2.0.0-internal.1.0.0 to be identified as internal. Haven't had time to check myself. Everything else looks good.
@tylerbutler, that would be a problem in test-version-utils because ^2.0.0-interna.1.0.0 is not restricted to internal versions. And that is something that the current tests check. Test case is "^2.0.0-internal.2.2.1 is not internal".
There is a question for you about handling of exact constraint during bump.
@tylerbutler, that would be a problem in test-version-utils because ^2.0.0-interna.1.0.0 is not restricted to internal versions. And that is something that the current tests check. Test case is "^2.0.0-internal.2.2.1 is not internal".
I think I have been misunderstanding this comment. I read it as "test-version-utils will break once this is merged" but I think what you're actually saying is that we already had a test here in version-utils that was verifying ^2.0.0-internal.2.2.1 is not internal, so my concern is unfounded.