FluidFramework icon indicating copy to clipboard operation
FluidFramework copied to clipboard

fix(build-tools): mixed internal range detection

Open jason-ha opened this issue 1 year ago • 2 comments

better inspect complex ranges with || handle cross prerelease rejection in single range set

refactor tests to see examples in table form

jason-ha avatar Dec 14 '23 17:12 jason-ha

My only concern is if test-version-utils in the client release group is expecting ^2.0.0-internal.1.0.0 to be identified as internal. Haven't had time to check myself. Everything else looks good.

tylerbutler avatar Feb 03 '24 02:02 tylerbutler

My only concern is if test-version-utils in the client release group is expecting ^2.0.0-internal.1.0.0 to be identified as internal. Haven't had time to check myself. Everything else looks good.

@tylerbutler, that would be a problem in test-version-utils because ^2.0.0-interna.1.0.0 is not restricted to internal versions. And that is something that the current tests check. Test case is "^2.0.0-internal.2.2.1 is not internal".

There is a question for you about handling of exact constraint during bump.

jason-ha avatar Feb 07 '24 07:02 jason-ha

@tylerbutler, that would be a problem in test-version-utils because ^2.0.0-interna.1.0.0 is not restricted to internal versions. And that is something that the current tests check. Test case is "^2.0.0-internal.2.2.1 is not internal".

I think I have been misunderstanding this comment. I read it as "test-version-utils will break once this is merged" but I think what you're actually saying is that we already had a test here in version-utils that was verifying ^2.0.0-internal.2.2.1 is not internal, so my concern is unfounded.

tylerbutler avatar Mar 22 '24 19:03 tylerbutler