FluidFramework icon indicating copy to clipboard operation
FluidFramework copied to clipboard

[v2int/1.1] Restore bindToContext functionality

Open markfields opened this issue 2 years ago • 4 comments

After discussing the challenges being faced by our internal partners integrating the 2.0.0-internal.1.1.x release due to the removal of bindToContext (see #10627), we're adding it back in. They are tracking the work required to fully migrate off the request pattern to using handles, which will render this fully obsolete and at that point we will remove it.

Does this introduce a breaking change?

No... it undoes a breaking change, such that this change is additive. Typically I think we avoid even backwards-compatible API changes in patch releases, but all interfaces being modified are for internal use only (we don't expect partners to be implementing them). And this is required to unblock our partner integrating the release.

markfields avatar Sep 20 '22 20:09 markfields

Could not find a usable baseline build with search starting at CI cccd76c6b712d9273745eebf659b4441e32de94c

Generated by :no_entry_sign: dangerJS against 7cd9b64d5515b906711f542a8f9c1d716e8f3cab

msfluid-bot avatar Sep 20 '22 22:09 msfluid-bot

looks ok. in general, i would usually check in in main first, then back port to all necessary branches

anthony-murphy avatar Sep 20 '22 22:09 anthony-murphy

Looks good. Can you please add tests for the scenario where in detached container, data stores are requested while its parent data store is initializing.

agarwal-navin avatar Sep 21 '22 17:09 agarwal-navin

Will merge after #12062 is merged into main (same change)

markfields avatar Sep 21 '22 22:09 markfields

Update: Planning to hold on this until next week when FF/Bohemia stakeholders have a chance to discuss and agree upon a long term plan for this API (i.e. when we can remove it for good)

markfields avatar Sep 22 '22 17:09 markfields