FluidFramework icon indicating copy to clipboard operation
FluidFramework copied to clipboard

Revert special case to make use of lastsummary's base path when parentSkipRecursion is set (completeSummaryCore)

Open NicholasCouri opened this issue 3 years ago • 1 comments

Now that we update the summarizer node with its base summary (since PR PR 11809) there is no need to special case and make use of the lastsummary's basepath whenever we have parentSkipRecursion set.

I've kept the test added by [PR 11697)(https://github.com/microsoft/FluidFramework/pull/11697) and made sure it is still passing without the summary upload error.

NicholasCouri avatar Sep 15 '22 00:09 NicholasCouri

@fluid-example/bundle-size-tests: -194 Bytes
Metric NameBaseline SizeCompare SizeSize Diff
aqueduct.js 401.74 KB 401.65 KB -97 Bytes
connectionState.js 680 Bytes 680 Bytes No change
containerRuntime.js 200.2 KB 200.1 KB -97 Bytes
loader.js 154.1 KB 154.1 KB No change
map.js 47.59 KB 47.59 KB No change
matrix.js 138.37 KB 138.37 KB No change
odspDriver.js 152.38 KB 152.38 KB No change
odspPrefetchSnapshot.js 39.75 KB 39.75 KB No change
sharedString.js 158.5 KB 158.5 KB No change
Total Size 1.29 MB 1.29 MB -194 Bytes

Baseline commit: ba1041abbc4085c064d047eea0e7b1c4470b2e76

Generated by :no_entry_sign: dangerJS against 85ccf36bf80c74a123e8a183bfb1e4d95486c065

msfluid-bot avatar Sep 15 '22 00:09 msfluid-bot

Hello @NicholasCouri!

Because this pull request has the msftbot: merge-next label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

ghost avatar Oct 06 '22 16:10 ghost