FluidFramework icon indicating copy to clipboard operation
FluidFramework copied to clipboard

Clean up `test:types` npm scripts

Open alexvy86 opened this issue 2 years ago • 0 comments

Description

I noticed that some of our release group root-level package.json files define a test:types npm script that in all cases does effectively nothing, because no packages inside the Lerna monorepos have a test:types script. This makes sense since the type validation tests are "static"; once they are generated, they cause build errors in the corresponding test project. No need to run them like we run mocha tests.

This PR removes said npm scripts from the root package.json files just to keep things lean.

The only remaining instances of the string type:tests in the repo are in package.json in common/lib/common-utils, but they actually refer to scripts that build the type validation tests.

image

Reviewer Guidance

I ran policy check and it didn't complain. I can't think of anything else that might want those npm scripts there.

alexvy86 avatar Aug 02 '22 22:08 alexvy86