FluidFramework
FluidFramework copied to clipboard
Add concurrent op check
Description
AB#1092 This PR adds assertions to DeltaManager and ContainerRuntime to ensure that ops are not being sent while currently being processsed. Currently this is happening unchecked, leading to non-deterministic outcomes.
Reviewer Guidance
- I added a counter to the appropriate submit and process functions but not sure if there's anything else I may be missing. Is my implementation of the assertion correct?
Please add breaking.md note about these changes, how users can temporarily disable it, and the fact that they will lose such capability in the future, thus need to fix any bugs it finds.
⯅ @fluid-example/bundle-size-tests: +438 Bytes
Metric Name | Baseline Size | Compare Size | Size Diff |
---|---|---|---|
aqueduct.js | 392.81 KB | 392.81 KB | ■ No change |
connectionState.js | 680 Bytes | 680 Bytes | ■ No change |
containerRuntime.js | 191.79 KB | 191.79 KB | ■ No change |
loader.js | 151.12 KB | 151.55 KB | ⯅ +438 Bytes |
map.js | 42.63 KB | 42.63 KB | ■ No change |
matrix.js | 131.62 KB | 131.62 KB | ■ No change |
odspDriver.js | 150.23 KB | 150.23 KB | ■ No change |
odspPrefetchSnapshot.js | 38.39 KB | 38.39 KB | ■ No change |
sharedString.js | 152.92 KB | 152.92 KB | ■ No change |
Total Size | 1.25 MB | 1.25 MB | ⯅ +438 Bytes |
Baseline commit: 938c55e7a57d624bc72d2d396e166300a6b25fc7
Generated by :no_entry_sign: dangerJS against c0914fe23f0dc43b6791e441d0eb2c7bac233894
This commit is queued for merging with the next
branch! Please ignore this PR for now. Contact @microsoft/fluid-cr-infra for help.