FluidFramework icon indicating copy to clipboard operation
FluidFramework copied to clipboard
verified publisher icon microsoft

feat(snapshots): use semantic equality for SharedMatrix in snapshot tests

Open connorskees opened this issue 3 years ago • 2 comments

Description

Two equivalent SharedMatrices can differ in exact cell content, but still be semantically equal when referenced by all public APIs. We work around this by special-casing equality for matrices in snapshot tests to rely on cell access exclusively through getCell.

ADO 432

connorskees avatar Jul 26 '22 17:07 connorskees

one other thing--fill out description before completing the PR please (just some basic context about how matrices' internal representation may differ on different clients thus the need for this should be fine)

Abe27342 avatar Aug 02 '22 18:08 Abe27342

fill out description before completing the PR please

Thank you for this reminder! I had intended to fill this out before marking the PR ready for review. I will do so after standup.

connorskees avatar Aug 02 '22 18:08 connorskees

This commit is queued for merging with the next branch! Please ignore this PR for now. Contact @microsoft/fluid-cr-infra for help.

github-actions[bot] avatar Aug 15 '22 14:08 github-actions[bot]