FluidFramework icon indicating copy to clipboard operation
FluidFramework copied to clipboard

ODSP: documentId -> relaySessionId

Open vladsud opened this issue 2 years ago • 3 comments

vladsud avatar Jul 19 '22 00:07 vladsud

@fluid-example/bundle-size-tests: +28 Bytes
Metric NameBaseline SizeCompare SizeSize Diff
aqueduct.js 386.43 KB 386.43 KB No change
connectionState.js 680 Bytes 680 Bytes No change
containerRuntime.js 191.59 KB 191.59 KB No change
loader.js 149.91 KB 149.91 KB -2 Bytes
map.js 42.67 KB 42.67 KB No change
matrix.js 126.19 KB 126.19 KB No change
odspDriver.js 148.93 KB 148.96 KB +30 Bytes
odspPrefetchSnapshot.js 38.17 KB 38.17 KB No change
sharedString.js 146.74 KB 146.74 KB No change
Total Size 1.23 MB 1.23 MB +28 Bytes

Baseline commit: c4a114373c1bab790257eb50515f62d8dd4a831a

Generated by :no_entry_sign: dangerJS against 51082d864146dd2faebb6b1e48bd4e7ba57d5cc4

msfluid-bot avatar Jul 19 '22 00:07 msfluid-bot

On the SPO & Push side, SessionId = "{tenantId}/{documentId}" A documentId by itself is not useful. It's both strings together that actually point to a session.

This change might cause some confusion since it will mismatch with how the server has things setup.

GaryWilber avatar Jul 19 '22 17:07 GaryWilber

@GaryWilber, how would you call that ID then? we need some name for it. :)

vladsud avatar Jul 19 '22 18:07 vladsud

This PR has been automatically marked as stale because it has had no activity for 60 days. It will be closed if no further activity occurs within 8 days of this comment. Thank you for your contributions to Fluid Framework!

ghost avatar Dec 13 '22 00:12 ghost