FLAML icon indicating copy to clipboard operation
FLAML copied to clipboard

Missing assignment of self._kwargs in TemporalFusionTransformerEstimator prior to call

Open gmdiana-hershey opened this issue 3 years ago • 1 comments

I've been experimenting with TFT, and ran into an issue running this line https://github.com/microsoft/FLAML/blob/74557472ececcd9a90b2f7a0938c73e1cdacf326/flaml/model.py#L2290. The source code seems to be missing that assignment, as opposed to the TransformersEstimator, which has it https://github.com/microsoft/FLAML/blob/74557472ececcd9a90b2f7a0938c73e1cdacf326/flaml/model.py#L619.

gmdiana-hershey avatar Sep 15 '22 13:09 gmdiana-hershey

oh I see the issue. should be a minor fix to gpus=kwargs.get("gpu_per_trial", [0]). Can you submit a quick pr that changes that?

int-chaos avatar Sep 20 '22 23:09 int-chaos