EdgeML icon indicating copy to clipboard operation
EdgeML copied to clipboard

Conv1d and batchnorm1d layers

Open AnirudhBHarish opened this issue 5 years ago • 5 comments

AnirudhBHarish avatar Oct 09 '20 14:10 AnirudhBHarish

CLA assistant check
All CLA requirements met.

ghost avatar Oct 09 '20 14:10 ghost

Also can we have more expressive macro names than O_T, I_T, O_F and I_F in the weight files?

ShikharJ avatar Oct 17 '20 19:10 ShikharJ

Also can we have more expressive macro names than O_T, I_T, O_F and I_F in the weight files?

I've incorporated all the modifications as instructed. I'll work on unifying the test benches and will rectify the macro expressiveness . I'll make these changes and push the commit for the same shortly

AnirudhBHarish avatar Oct 17 '20 21:10 AnirudhBHarish

Also can we have more expressive macro names than O_T, I_T, O_F and I_F in the weight files?

I've changed the macros to a more expressive name. I have also combined the test-bench files as mentioned above

AnirudhBHarish avatar Oct 18 '20 12:10 AnirudhBHarish

Sorry for the delay in the new commit. All the changes have been made. I have even added a couple of extra lines of comments for the error metrics for better clarity.

AnirudhBHarish avatar Oct 12 '21 20:10 AnirudhBHarish