EdgeML icon indicating copy to clipboard operation
EdgeML copied to clipboard
verified publisher icon microsoft

FastCell Example Fixes, Generalized trainer for both batch_first args

Open SachinG007 opened this issue 5 years ago • 4 comments

Checked the changes with Aditya

SachinG007 avatar Apr 30 '20 12:04 SachinG007

@oindrilasaha would be good if you can have a look at this PR

SachinG007 avatar May 03 '20 01:05 SachinG007

@SachinG007 please incorporate the changes from #173 for the fixing of optimizer for FC. Earlier gradient updates were not happening for FC due to some convention mismatch. Please look at this: https://github.com/microsoft/EdgeML/pull/173/files#diff-7b39dde7dda6360cbf530db88f5b9f8dR12-R62 and incorporate it.

Also, try to keep PRs for different things separate. When we are fixing fastcell_Example.py related stuff, let us stick to that. Thanks

adityakusupati avatar May 03 '20 04:05 adityakusupati

@adityakusupati , incorporated the changes from PR#173.

SachinG007 avatar May 06 '20 20:05 SachinG007

@SachinG007 any updates on this PR?

adityakusupati avatar Oct 09 '20 04:10 adityakusupati