DirectXShaderCompiler icon indicating copy to clipboard operation
DirectXShaderCompiler copied to clipboard

Published 20 hours ago • verified publisher icon microsoft

fix non-portable include path

Open ukai opened this issue 11 months ago • 2 comments

d3dcommon.h seems to be canonical path name in Win SDK

Windows Kits/10/Include/10.0.22621.0/um/d3dcommon.h

so use d3dcommon.h rather than D3Dcommon.h

ukai avatar Mar 04 '24 05:03 ukai

:white_check_mark: With the latest revision this PR passed the C/C++ code formatter.

github-actions[bot] avatar Mar 04 '24 05:03 github-actions[bot]

@microsoft-github-policy-service agree

ukai avatar Mar 06 '24 06:03 ukai

Is there anything left to do here to get this merged? :)

philwo avatar Mar 26 '24 03:03 philwo

Thanks for the contribution @ukai! While this is clearly a correct change, I was curious what made this necessary given that they are windows-specific files. That's why they were missed from previous efforts to make building portable.

pow2clk avatar Mar 26 '24 16:03 pow2clk

@pow2clk Thanks for asking :)

@ukai and I are working on Chromium's build system. We want to make it as easy as possible for developers to work on Chromium for all supported platforms, no matter what OS they use on their developer machine. Sometimes we stumble upon portability issues in a dependency used by our build that way, like this one or https://github.com/microsoft/DirectXShaderCompiler/pull/6379.

We have some docs for contributors who want to build Chromium for Windows from their Linux or Mac here, if you're interested: https://chromium.googlesource.com/chromium/src/+/master/docs/win_cross.md

philwo avatar Mar 26 '24 23:03 philwo